Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(measure_theory/function/conditional_expectation): change the definition of condexp and its notation #14010

Closed
wants to merge 6 commits into from

Conversation

RemyDegenne
Copy link
Collaborator

@RemyDegenne RemyDegenne commented May 7, 2022

Before this PR, the conditional expectation condexp was defined using an argument (hm : m ≤ m0).
This changes the definition to take only m, and assigns the default value 0 if we don't have m ≤ m0.

The notation for condexp m μ f is simplified to μ[f|m].

The change makes the proofs of the condexp API longer, but no change is needed to lemmas outside of that file. See the file martingale.lean: the notation is now simpler, but otherwise little else changes besides removing the now unused argument [sigma_finite_filtration μ ℱ] from many lemmas.

Also add an instance is_finite_measure.sigma_finite_filtration: we had a lemma with both is_finite_measure and sigma_finite_filtration arguments, but the first one implies the other.


Open in Gitpod

@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label May 7, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed much nicer, very good idea!

src/measure_theory/function/conditional_expectation.lean Outdated Show resolved Hide resolved
src/measure_theory/function/conditional_expectation.lean Outdated Show resolved Hide resolved
src/measure_theory/function/conditional_expectation.lean Outdated Show resolved Hide resolved
src/measure_theory/function/conditional_expectation.lean Outdated Show resolved Hide resolved
@sgouezel
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented May 10, 2022

✌️ RemyDegenne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels May 10, 2022
@RemyDegenne
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 11, 2022
bors bot pushed a commit that referenced this pull request May 11, 2022
…finition of condexp and its notation (#14010)

Before this PR, the conditional expectation `condexp` was defined using an argument `(hm : m ≤ m0)`.
This changes the definition to take only `m`, and assigns the default value 0 if we don't have `m ≤ m0`.

The notation for `condexp m μ f` is simplified to `μ[f|m]`.

The change makes the proofs of the condexp API longer, but no change is needed to lemmas outside of that file. See the file `martingale.lean`: the notation is now simpler, but otherwise little else changes besides removing the now unused argument `[sigma_finite_filtration μ ℱ]` from many lemmas.

Also add an instance `is_finite_measure.sigma_finite_filtration`: we had a lemma with both `is_finite_measure` and `sigma_finite_filtration` arguments, but the first one implies the other.
@bors
Copy link

bors bot commented May 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(measure_theory/function/conditional_expectation): change the definition of condexp and its notation [Merged by Bors] - chore(measure_theory/function/conditional_expectation): change the definition of condexp and its notation May 11, 2022
@bors bors bot closed this May 11, 2022
@bors bors bot deleted the condexp_notation branch May 11, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants