New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(algebra/{group,group_with_zero/basic): Delete lemmas generalized to division monoids #14042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work! Everything looks sensible, so let's merge this when it builds.
bors d+
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
👎 Rejected by label |
(We're just waiting for lint and it was already working before the last master merge) bors merge |
Pull request successfully merged into master. Build succeeded: |
Delete the
group
andgroup_with_zero
lemmas which have been made one-liners in #14000.Lemmas are renamed because
group
orgroup_with_zero
name has to goLemma renames
group
lemma,group_with_zero
lemma → newdivision_monoid
/division_comm_monoid
lemmainv_eq_of_mul_left_eq_one
→inv_eq_of_mul_eq_one_left
inv_eq_of_mul_eq_one
,inv_eq_of_mul_right_eq_one
→inv_eq_of_mul_eq_one_right
eq_inv_of_mul_eq_one
,eq_inv_of_mul_left_eq_one
→eq_inv_of_mul_eq_one_left
eq_inv_of_mul_right_eq_one
→eq_inv_of_mul_eq_one_right
eq_one_div_of_mul_eq_one
→eq_one_div_of_mul_eq_one_right
inv_div'
,inv_div
→inv_div
div_one'
,div_one
→div_one
eq_of_div_eq_one'
,eq_of_div_eq_one
→eq_of_div_eq_one
div_eq_inv_mul'
,div_eq_inv_mul
→div_eq_inv_mul
div_right_comm'
,div_right_comm
→div_right_comm
div_mul_eq_mul_div'
,div_mul_eq_mul_div
→div_mul_eq_mul_div
div_mul_comm
,div_mul_comm'
→div_mul_comm
mul_comm_div'
,div_mul_eq_mul_div_comm
→mul_comm_div
mul_div_comm
→mul_div_left_comm
mul_inv
,mul_inv₀
→mul_inv
inv_eq_one
,inv_eq_one₀
→inv_eq_one
one_eq_inv
,one_eq_inv₀
→one_eq_inv
div_div_div_comm
,div_div_div_comm₀
→div_div_div_comm
div_mul_div_comm
,div_mul_div_comm₀
→div_mul_div_comm
mul_div_comm'
, - →mul_div_mul_comm
div_div_div_div_eq
→div_div_div_eq
one_inv
,inv_one
→inv_one
div_div
,div_div_eq_div_mul
→div_div
mul_div_left_comm
,mul_div_comm
→mul_div_left_comm
div_div_assoc_swap
,div_div_eq_mul_div
→div_div_eq_mul_div
Other changes
I found that splitting the refactor in this unusual way allowed me to have a cleaner diff and be systematically sure that I wasn't missing lemmas. The only problem is that I have to unsimp the old lemmas.
Here's what to look out for if you want to check for yourself:
group
/group_with_zero
disparity or naming consistency within the new API.simp
andfield_simp
are copied correctly.group
/group_with_zero
lemma has been deleted.