[Merged by Bors] - chore(data/real/ennreal): style and golfing #14055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbuzzard
added
the
awaiting-review
dupuisf
reviewed
May 10, 2022
Comment on lines
+1221
to
1222
| -- *TODO* this should surely be called div_mul_cancel? | ||
| lemma mul_div_cancel (h0 : a ≠ 0) (hI : a ≠ ∞) : (b / a) * a = b := |
There was a problem hiding this comment.
I agree! However I get 295 hits for "mul_div_cancel" in a quick search in VSCode, so let's leave that for another PR :-)
There was a problem hiding this comment.
I think most of them are not ennreal though :-)
leanprover-community-bot-assistant
added
ready-to-merge
vihdzp
changed the title
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using
ennrealso I thought I'd read through the file. This rather trivial PR golfs some proofs and makes the style conform a bit more to the mathlib conventions. No lemmas are added or deleted.