[Merged by Bors] - perf(field_theory/primitive_element): declare auxiliary function noncomputable!
#14071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…computable!` The declaration `roots_of_min_poly_pi_type` is computable, so it gets compiled. Unfortunately, compilation takes about 2-3s on my machine (and times out under #11759). Since the parameters are all elements of noncomputable types, nobody will care if we explicitly make it computable, and it saves a lot of compilation time. See also this Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Timeout/near/278494746
Vierkantor
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 13, 2022
…computable!` (#14071) The declaration `roots_of_min_poly_pi_type` is computable and gets compiled by Lean. Unfortunately, compilation takes about 2-3s on my machine and times out under #11759 (with timeouts disabled, it takes about 11s on that branch). Since the parameters are all elements of noncomputable types and its only use is a noncomputable `fintype` instance, nobody will care if we explicitly make it computable, and it saves a lot of compilation time. See also this Zulip thread on `noncomputable!` fixing mysterious timeouts: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Timeout/near/278494746
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
noncomputable!noncomputable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declaration
roots_of_min_poly_pi_typeis computable and gets compiled by Lean. Unfortunately, compilation takes about 2-3s on my machine and times out under #11759 (with timeouts disabled, it takes about 11s on that branch). Since the parameters are all elements of noncomputable types and its only use is a noncomputablefintypeinstance, nobody will care if we explicitly make it computable, and it saves a lot of compilation time.See also this Zulip thread on
noncomputable!fixing mysterious timeouts: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Timeout/near/278494746