Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/polynomial/degree/definitions): if r ≠ 0, then (monomial i r).nat_degree = i #14095

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(data/polynomial/degree/definitions): if r ≠ 0, then (monomial i r).nat_degree = i #14095

wants to merge 4 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented May 12, 2022

Add a lemma analogous to nat_degree_C_mul_X_pow and nat_degree_C_mul_X.

Open in Gitpod

@adomani
Copy link
Collaborator Author

adomani commented May 12, 2022

Ok, I went for a compromise: I left the term-mode proof, but added the decidable assumption! Does this look reasonable?

@vihdzp
Copy link
Collaborator

vihdzp commented May 12, 2022

Yeah, this looks nice.

@adomani adomani added the awaiting-review The author would like community review of the PR label May 12, 2022
@adomani adomani mentioned this pull request May 12, 2022
Closed
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 12, 2022
bors bot pushed a commit that referenced this pull request May 12, 2022
@adomani
feat(data/polynomial/degree/definitions): if r ≠ 0, then `(monomial…
c2e87de 
… i r).nat_degree = i` (#14095)

Add a lemma analogous to `nat_degree_C_mul_X_pow` and `nat_degree_C_mul_X`.
@bors
Copy link

bors bot commented May 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/polynomial/degree/definitions): if r ≠ 0, then (monomial i r).nat_degree = i [Merged by Bors] - feat(data/polynomial/degree/definitions): if r ≠ 0, then (monomial i r).nat_degree = i May 12, 2022
@bors bors bot closed this May 12, 2022
@bors bors bot deleted the adomani_monomial_nat_degree branch May 12, 2022 12:10
bors bot pushed a commit that referenced this pull request May 13, 2022
@adomani
feat(data/polynomial/degree/definitions): two more nat_degree_le le…
b7e20ca 
…mmas (#14098)

This PR is similar to #14095.  It proves the `le` version of `nat_degree_X_pow` and `nat_degree_monomial`.

These lemmas are analogous to the existing `nat_degree_X_le` and `nat_degree_C_mul_X_pow_le`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca riccardobrasca left review comments

@vihdzp vihdzp vihdzp left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adomani @vihdzp @riccardobrasca