[Merged by Bors] - feat(order/filter/at_top_bot): use weaker TC assumptions, add lemmas #14105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `filter.eventually_gt_of_tendsto_at_top`, `filter.eventually_ne_at_bot`, `filter.eventually_lt_of_tendsto_at_bot`; * generalize `filter.eventually_ne_of_tendsto_at_top` and `filter.eventually_ne_of_tendsto_at_bot` from nontrivial ordered (semi)rings to preorders with no maximal/minimal elements.
urkud
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
b-mehta
approved these changes
May 12, 2022
src/order/filter/at_top_bot.lean
Outdated
| (eventually_gt_at_top a).mono (λ x hx, hx.ne.symm) | ||
| (eventually_gt_at_top a).mono $ λ x, ne_of_gt | ||
|
|
||
| lemma eventually_gt_of_tendsto_at_top [preorder β] [no_max_order β] {f : α → β} {l : filter α} |
There was a problem hiding this comment.
I think it would be useful to have the eventually_ge version of this too
src/order/filter/at_top_bot.lean
Outdated
| (eventually_gt_at_top a).mono (λ x hx, hx.ne.symm) | ||
| (eventually_gt_at_top a).mono $ λ x, ne_of_gt | ||
|
|
||
| lemma eventually_gt_of_tendsto_at_top [preorder β] [no_max_order β] {f : α → β} {l : filter α} |
There was a problem hiding this comment.
Perhaps tendsto.eventually_gt_at_top to allow dot notation?
There was a problem hiding this comment.
Feel free to adopt this PR. I usually use h.eventually (eventually_??_at_top _). I've just noticed that we have lemmas that assume [ordered_ring R] for no reason.
urkud
added
the
please-adopt
b-mehta
removed
the
please-adopt
urkud
commented
May 12, 2022
b-mehta
reviewed
May 13, 2022
urkud
commented
May 13, 2022
urkud
commented
May 13, 2022
|
@b-mehta I fixed compile errors. |
|
Thanks for that @urkud! |
|
@b-mehta Should we merge it now or wait for a review from one more maintainer? |
|
I think we should wait for another maintainer to take a look. Perhaps @RemyDegenne? |
|
LGTM |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 16, 2022
…14105) * add `filter.eventually_gt_of_tendsto_at_top`, `filter.eventually_ne_at_bot`, `filter.eventually_lt_of_tendsto_at_bot`; * generalize `filter.eventually_ne_of_tendsto_at_top` and `filter.eventually_ne_of_tendsto_at_bot` from nontrivial ordered (semi)rings to preorders with no maximal/minimal elements. Co-authored-by: Bhavik Mehta <bm489@cam.ac.uk> Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
filter.eventually_gt_of_tendsto_at_top,filter.eventually_ne_at_bot,filter.eventually_lt_of_tendsto_at_bot;generalize
filter.eventually_ne_of_tendsto_at_topandfilter.eventually_ne_of_tendsto_at_botfrom nontrivial ordered(semi)rings to preorders with no maximal/minimal elements.