[Merged by Bors] - feat(set_theory/ordinal/arithmetic): Add missing instances for ordinal
#14128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
easy
vihdzp
changed the title
monoid_with_zero instance for ordinalordinal
1 task
vihdzp
removed
the
easy
eric-wieser
reviewed
May 13, 2022
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
|
This looks good. Thanks! bors d+ (This might conflict with some other PRs I put on the queue, so I'm just delegating it) |
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 28, 2022
…al` (#14128) We add the following instances: - `monoid_with_zero ordinal` - `no_zero_divisors ordinal` - `is_left_distrib_class ordinal` - `contravariant_class ordinal ordinal (swap (+)) (<)` - `is_antisymm ordinal (∣)`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ordinalordinal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the following instances:
monoid_with_zero ordinalno_zero_divisors ordinalis_left_distrib_class ordinalcontravariant_class ordinal ordinal (swap (+)) (<)is_antisymm ordinal (∣)Let me know if there's other missing instances here, I'm not very familiar with the algebraic hierarchy in mathlib.