feat(data/list/defs): move list.sum to list/defs.lean #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHughes24
approved these changes
Sep 8, 2019
ChrisHughes24
added
the
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…munity#1415) * feat(data/list/defs): move list.sum to list/defs.lean * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
list.prodis defined tolist/defs.lean, butlist.sumwaits untillist/basic.lean, by which time we haveto_additiveavailable. This PR instead defineslist.sumin parallel withlist.prodby hand, and tags it usingto_additiveinlist/basic.lean.(I was tripped up by this while formalising an IMO problem, where I was trying to work with minimal imports.)