Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(set_theory/surreal/basic): golf #14168

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - chore(set_theory/surreal/basic): golf #14168

wants to merge 9 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented May 16, 2022 •
edited

We also add some basic lemmas for simplifying the definition of numeric when either a game's left or right moves are empty.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label May 16, 2022
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 16, 2022
@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 17, 2022
urkud
urkud reviewed Jun 4, 2022
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left two optional suggestions. Otherwise LGTM.
bors d+

src/set_theory/surreal/basic.lean Outdated Show resolved Hide resolved
src/set_theory/surreal/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 4, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 4, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Jun 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 4, 2022
@vihdzp
chore(set_theory/surreal/basic): golf (#14168)
a418945 
We also add some basic lemmas for simplifying the definition of `numeric` when either a game's left or right moves are empty.
@bors
Copy link

bors bot commented Jun 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(set_theory/surreal/basic): golf [Merged by Bors] - chore(set_theory/surreal/basic): golf Jun 4, 2022
@bors bors bot closed this Jun 4, 2022
@bors bors bot deleted the minor_surreal_golf branch June 4, 2022 05:34
tomaz1502 pushed a commit that referenced this pull request Jun 5, 2022
@vihdzp @tomaz1502
chore(set_theory/surreal/basic): golf (#14168)
8a5bf1b 
We also add some basic lemmas for simplifying the definition of `numeric` when either a game's left or right moves are empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vihdzp @urkud @eric-wieser @leanprover-community-bot-assistant