Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/lie/centralizer): define the centralizer of a Lie submodule and the upper central series #14173

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(algebra/lie/centralizer): define the centralizer of a Lie submodule and the upper central series #14173

wants to merge 4 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented May 16, 2022

Open in Gitpod

@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label May 16, 2022
@ocfnash ocfnash requested a review from jcommelin May 16, 2022 09:36
@ocfnash ocfnash mentioned this pull request May 16, 2022
Closed
1 task
@eric-wieser eric-wieser changed the title feat(algbera/lie/centralizer): define the centralizer of a Lie submodule and the upper central series feat(algebra/lie/centralizer): define the centralizer of a Lie submodule and the upper central series May 16, 2022
@ocfnash ocfnash mentioned this pull request May 16, 2022
Closed
2 tasks
riccardobrasca
riccardobrasca reviewed May 27, 2022
View reviewed changes
src/algebra/lie/centralizer.lean Outdated Show resolved Hide resolved
src/algebra/lie/centralizer.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

This all looks reasonable to me; although I'm no lie expert. Only a few nits.

src/algebra/lie/centralizer.lean Outdated Show resolved Hide resolved
src/algebra/lie/centralizer.lean Outdated Show resolved Hide resolved
src/algebra/lie/nilpotent.lean Outdated Show resolved Hide resolved
src/algebra/lie/centralizer.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 8, 2022

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 8, 2022
@ocfnash
Copy link
Collaborator Author

ocfnash commented Jun 8, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 8, 2022
bors bot pushed a commit that referenced this pull request Jun 8, 2022
@ocfnash
feat(algebra/lie/centralizer): define the centralizer of a Lie submod…
65fba4c 
…ule and the upper central series (#14173)
@bors
Copy link

bors bot commented Jun 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/lie/centralizer): define the centralizer of a Lie submodule and the upper central series [Merged by Bors] - feat(algebra/lie/centralizer): define the centralizer of a Lie submodule and the upper central series Jun 8, 2022
@bors bors bot closed this Jun 8, 2022
@bors bors bot deleted the ocfnash/lie_ucs branch June 8, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@riccardobrasca riccardobrasca riccardobrasca left review comments

@jcommelin jcommelin Awaiting requested review from jcommelin

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocfnash @eric-wieser @riccardobrasca @leanprover-community-bot-assistant