Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/order/ring): golf mul_le_one #14245

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(algebra/order/ring): golf mul_le_one #14245

wants to merge 4 commits into from

Conversation

stuart-presnell
Copy link
Collaborator

@stuart-presnell stuart-presnell commented May 19, 2022 •
edited

golf mul_le_one

Open in Gitpod

@stuart-presnell stuart-presnell added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels May 19, 2022
@stuart-presnell
Remove decidable version
f89170b 
`#lint` says the `[@decidable_rel α (≤)]` isn't used
@stuart-presnell stuart-presnell changed the title feat(algebra/order/ring): add mul_lt_one; golf mul_le_one chore(algebra/order/ring): golf mul_le_one May 19, 2022
@urkud
Copy link
Member

urkud commented May 22, 2022

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 22, 2022
bors bot pushed a commit that referenced this pull request May 22, 2022
@stuart-presnell
chore(algebra/order/ring): golf mul_le_one (#14245)
9b8588a 
golf `mul_le_one`
@bors
Copy link

bors bot commented May 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/order/ring): golf mul_le_one [Merged by Bors] - chore(algebra/order/ring): golf mul_le_one May 22, 2022
@bors bors bot closed this May 22, 2022
@bors bors bot deleted the SP_mul_lt_one branch May 22, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stuart-presnell @urkud @YaelDillies