Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/real/ennreal): lemmas about unions and intersections #14296

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(data/real/ennreal): lemmas about unions and intersections #14296

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 22, 2022

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels May 22, 2022
@urkud urkud mentioned this pull request May 22, 2022
Open
3 tasks
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 22, 2022
eric-wieser
eric-wieser reviewed May 22, 2022
View reviewed changes
src/data/real/ennreal.lean
subset.antisymm (Union_subset $ λ n x hx, ne_top_of_le_ne_top coe_nat_ne_top hx) $
Union_Iio_coe_nat ▸ Union_mono (λ n, Iio_subset_Iic_self)

@[simp] lemma Union_Ioc_coe_nat : (⋃ n : ℕ, Ioc a n) = Ioi a \ {∞} :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same as

Suggested change
@[simp] lemma Union_Ioc_coe_nat : (⋃ n : ℕ, Ioc a n) = Ioi a \ {∞} :=
@[simp] lemma Union_Ioc_coe_nat : (⋃ n : ℕ, Ioc a n) = Ioo a ∞ :=

eric-wieser
eric-wieser approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

I'd expect Ici a\ {∞} to be slightly worse than Ico a ∞ but am not certain

@bors
Copy link

bors bot commented May 22, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels May 22, 2022
@urkud
Copy link
Member Author

urkud commented May 22, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 22, 2022
bors bot pushed a commit that referenced this pull request May 22, 2022
@urkud
feat(data/real/ennreal): lemmas about unions and intersections (#14296)
e4a8db1
@bors
Copy link

bors bot commented May 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/real/ennreal): lemmas about unions and intersections [Merged by Bors] - feat(data/real/ennreal): lemmas about unions and intersections May 22, 2022
@bors bors bot closed this May 22, 2022
@bors bors bot deleted the YK-ennreal-Ixx branch May 22, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @eric-wieser @leanprover-community-bot-assistant