Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(representation_theory/monoid_algebra_basis): add some API for k[G^n] #14308

Closed
wants to merge 15 commits into from

Conversation

101damnations
Copy link
Collaborator


See this Zulip thread for discussion. I'm not sure what to call the file...
See this branch for what will be added to this file in future: a proof $k[G^{n + 1}]$ is free over $k[G]$ from the fact that $k[G^{n + 1}] \cong k[G] \otimes_k k[G^n].$

Open in Gitpod

@101damnations 101damnations added the awaiting-review The author would like community review of the PR label May 22, 2022
@semorrison semorrison mentioned this pull request May 25, 2022
@kbuzzard
Copy link
Member

kbuzzard commented Jun 9, 2022

This all looks very elegant -- it's definition-heavy, but I guess the branch linked to above is evidence that the definitions are usable!

101damnations and others added 4 commits June 12, 2022 14:21
There are no mathematical changes here. An approximate summary of
what has been done is:
  * Adjust module doc string a little
  * Adjust naming / namespacing
  * Regroup content to separate linear algebra from category-theoretic constructs
  * Regroup content to reduce implicit / explicit `variables` switching

The naming / namespacing still needs improvement.
Also:
 * clean up legacy `to_prod` naming
 * add missing `to_additive` decorators
@kbuzzard
Copy link
Member

@semorrison do you have anything to add? (I think Scott is unfortunately busy with other things right now)

@ocfnash ocfnash requested a review from eric-wieser June 29, 2022 22:00
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 11, 2022
bors bot pushed a commit that referenced this pull request Jul 11, 2022
…[G^n]` (#14308)




Co-authored-by: Oliver Nash <github@olivernash.org>
@bors
Copy link

bors bot commented Jul 11, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 11, 2022
…[G^n]` (#14308)




Co-authored-by: Oliver Nash <github@olivernash.org>
@bors
Copy link

bors bot commented Jul 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(representation_theory/monoid_algebra_basis): add some API for k[G^n] [Merged by Bors] - feat(representation_theory/monoid_algebra_basis): add some API for k[G^n] Jul 12, 2022
@bors bors bot closed this Jul 12, 2022
@bors bors bot deleted the monoid-algebra-basis branch July 12, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants