Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits): bicartesian squares #14375

Closed
wants to merge 25 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits): bicartesian squares #14375

wants to merge 25 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented May 25, 2022 •
edited by github-actions bot 

 X ⊞ Y --fst--> X
   |            |
  snd           0
   |            |
   v            v
   Y -----0---> 0

is a bicartesian square.

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels May 25, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 25, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 25, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 26, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@semorrison semorrison added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 19, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 26, 2022
jcommelin
jcommelin approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion for a docstring.

bors d+

src/category_theory/limits/shapes/comm_sq.lean Outdated Show resolved Hide resolved
src/category_theory/limits/shapes/comm_sq.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 11, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. t-category-theory Category theory and removed awaiting-review The author would like community review of the PR labels Aug 11, 2022
semorrison and others added 3 commits September 23, 2022 17:04
@semorrison @jcommelin
Apply suggestions from code review
59dfe46 
Co-authored-by: Johan Commelin <johan@commelin.net>
@semorrison
merge
40f5919
@semorrison
Merge branch 'semorrison/bicartesian' of github.com:leanprover-commun…
c594459 
…ity/mathlib into semorrison/bicartesian
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 23, 2022
bors bot pushed a commit that referenced this pull request Sep 23, 2022
@semorrison
feat(category_theory/limits): bicartesian squares (#14375)
c1e0789 
```
 X ⊞ Y --fst--> X
   |            |
  snd           0
   |            |
   v            v
   Y 

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 23, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 23, 2022
@semorrison
feat(category_theory/limits): bicartesian squares (#14375)
494498f 
```
 X ⊞ Y --fst--> X
   |            |
  snd           0
   |            |
   v            v
   Y 

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 23, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 23, 2022
@semorrison
feat(category_theory/limits): bicartesian squares (#14375)
fa1836d 
```
 X ⊞ Y --fst--> X
   |            |
  snd           0
   |            |
   v            v
   Y 

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 23, 2022

Build failed (retrying...):

@kmill
Copy link
Collaborator

kmill commented Sep 23, 2022

This PR seems to be a source of a bors build error with comm_sq. Taking it off the queue

bors r-

@bors
Copy link

bors bot commented Sep 23, 2022

Canceled.

@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 5, 2022
@semorrison
feat(category_theory/limits): bicartesian squares (#14375)
52a270e 
```
 X ⊞ Y --fst--> X
   |            |
  snd           0
   |            |
   v            v
   Y 

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): bicartesian squares [Merged by Bors] - feat(category_theory/limits): bicartesian squares Oct 5, 2022
@bors bors bot closed this Oct 5, 2022
@bors bors bot deleted the semorrison/bicartesian branch October 5, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @mathlib-dependent-issues-bot @kmill @jcommelin