Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set_theory/cardinal/cofinality): weaker definition for regular cardinals #14433

Closed
wants to merge 6 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented May 28, 2022

We weaken c.ord.cof = c to c ≤ c.ord.cof in the definition of regular cardinals, in order to slightly simplify proofs. The lemma is_regular.cof_eq shows that this leads to an equivalent definition.


I also golfed is_regular_succ slightly.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label May 28, 2022
@fpvandoorn
Copy link
Member

LGTM

bors d+

I think this conflicts with other PRs I just borsed

@bors
Copy link

bors bot commented Jun 4, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 4, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Jun 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 5, 2022
…ardinals (#14433)

We weaken `c.ord.cof = c` to `c ≤ c.ord.cof` in the definition of regular cardinals, in order to slightly simplify proofs. The lemma `is_regular.cof_eq` shows that this leads to an equivalent definition.
@bors
Copy link

bors bot commented Jun 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/cardinal/cofinality): weaker definition for regular cardinals [Merged by Bors] - feat(set_theory/cardinal/cofinality): weaker definition for regular cardinals Jun 5, 2022
@bors bors bot closed this Jun 5, 2022
@bors bors bot deleted the regular_weak branch June 5, 2022 02:47
tomaz1502 pushed a commit that referenced this pull request Jun 5, 2022
…ardinals (#14433)

We weaken `c.ord.cof = c` to `c ≤ c.ord.cof` in the definition of regular cardinals, in order to slightly simplify proofs. The lemma `is_regular.cof_eq` shows that this leads to an equivalent definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants