Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/dedekind_domain/ideal): drop an unneeded assumption #14444

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(ring_theory/dedekind_domain/ideal): drop an unneeded assumption #14444

wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 29, 2022

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels May 29, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 29, 2022
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 31, 2022
@urkud urkud added the please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. label May 31, 2022
@Vierkantor Vierkantor self-assigned this May 31, 2022
@Vierkantor Vierkantor added please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. and removed please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. labels May 31, 2022
@Vierkantor
Copy link
Collaborator

I'm very busy the next 2 weeks so I might not have time to investigate soon. If you need this earlier, feel free to adopt!

@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 17, 2022
Vierkantor
Vierkantor approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the (indirect) reminder! I added the lemma that I was talking about in my review.

@Vierkantor Vierkantor removed the please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. label Jun 21, 2022
ocfnash
ocfnash approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 21, 2022
bors bot pushed a commit that referenced this pull request Jun 21, 2022
@urkud @Vierkantor
feat(ring_theory/dedekind_domain/ideal): drop an unneeded assumption (#…
65031ca 
…14444)




Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
@bors
Copy link

bors bot commented Jun 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/dedekind_domain/ideal): drop an unneeded assumption [Merged by Bors] - feat(ring_theory/dedekind_domain/ideal): drop an unneeded assumption Jun 21, 2022
@bors bors bot closed this Jun 21, 2022
@bors bors bot deleted the YK-count-divisors branch June 21, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@ocfnash ocfnash ocfnash approved these changes

@jcommelin jcommelin Awaiting requested review from jcommelin

@riccardobrasca riccardobrasca Awaiting requested review from riccardobrasca

Assignees

@Vierkantor Vierkantor

Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @Vierkantor @ocfnash @leanprover-community-bot-assistant