Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/vector_bundle): redefine continuous coordinate change #14462

Closed
wants to merge 9 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented May 30, 2022

  • For any two trivializations, we define the coordinate change between the two trivializations: continous linear automorphism of F, defined by composing one trivialization with the inverse of the other. This is defined for any point in the intersection of their base sets, and we define it to be the identity function outside this set.
  • Redefine topological_vector_bundle: we now require that this coordinate change between any two trivializations is continuous on the intersection of their base sets.
  • Redefine topological_vector_prebundle with the existence of a continuous linear coordinate change function.
  • Simplify the proofs that the coordinate change function is continuous for constructions on vector bundles.

Zulip thread

Open in Gitpod

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels May 30, 2022
@fpvandoorn fpvandoorn requested a review from sgouezel May 30, 2022 14:31
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 30, 2022
@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 31, 2022
@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 31, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a change I've been wanting to do for some time, so I'm really glad you did it. Thanks!
bors d+

Comment on lines 396 to 397
def continuous_transitions (e : local_equiv (B × F) (B × F)) : Prop :=
∃ s : set B, e.source = s ×ˢ (univ : set F) ∧ e.target = s ×ˢ (univ : set F)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you remove this definition now?

Copy link
Member Author

@fpvandoorn fpvandoorn Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, my impression from @hrmacbeth was that she still wanted to use it. I'll delete it in a later PR if that is false.

@bors
Copy link

bors bot commented Jun 1, 2022

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 1, 2022
@sgouezel
Copy link
Collaborator

sgouezel commented Jun 1, 2022

Also, I don't think the PR description is accurate wrt topological_vector_prebundle, as the new definition does not include data.

@fpvandoorn
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 1, 2022
bors bot pushed a commit that referenced this pull request Jun 1, 2022
…14462)

* For any two trivializations, we define the coordinate change between the two trivializations: continous linear automorphism of `F`, defined by composing one trivialization with the inverse of the other. This is defined for any point in the intersection of their base sets, and we define it to be the identity function outside this set.
* Redefine `topological_vector_bundle`: we now require that this coordinate change between any two trivializations is continuous on the intersection of their base sets.
* Redefine `topological_vector_prebundle` with the existence of a continuous linear coordinate change function.
* Simplify the proofs that the coordinate change function is continuous for constructions on vector bundles.
@bors
Copy link

bors bot commented Jun 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/vector_bundle): redefine continuous coordinate change [Merged by Bors] - feat(topology/vector_bundle): redefine continuous coordinate change Jun 1, 2022
@bors bors bot closed this Jun 1, 2022
@bors bors bot deleted the continuous_coord_change branch June 1, 2022 12:54
tomaz1502 pushed a commit that referenced this pull request Jun 3, 2022
…14462)

* For any two trivializations, we define the coordinate change between the two trivializations: continous linear automorphism of `F`, defined by composing one trivialization with the inverse of the other. This is defined for any point in the intersection of their base sets, and we define it to be the identity function outside this set.
* Redefine `topological_vector_bundle`: we now require that this coordinate change between any two trivializations is continuous on the intersection of their base sets.
* Redefine `topological_vector_prebundle` with the existence of a continuous linear coordinate change function.
* Simplify the proofs that the coordinate change function is continuous for constructions on vector bundles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants