New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(order/directed): use (≥)
instead of swap (≤)
#14474
Conversation
urkud
commented
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My slight worry here is that all the covariant_class
stuff is stated with swap
, and while they likely don't interact directly, this makes thing inconsistent.
On the other hand, maybe we're fine to use (≥)
in those places too if swap
is reducible enough.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
I can see |
This seems like a clear improvement. If there are any bors merge |
Pull request successfully merged into master. Build succeeded: |
(≥)
instead of swap (≤)
(≥)
instead of swap (≤)