Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(order/directed): use (≥) instead of swap (≤) #14474

Closed
wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 31, 2022


Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels May 31, 2022
src/order/ideal.lean Outdated Show resolved Hide resolved
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My slight worry here is that all the covariant_class stuff is stated with swap, and while they likely don't interact directly, this makes thing inconsistent.

On the other hand, maybe we're fine to use (≥) in those places too if swap is reducible enough.

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 31, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@urkud
Copy link
Member Author

urkud commented May 31, 2022

My slight worry here is that all the covariant_class stuff is stated with swap, and while they likely don't interact directly, this makes thing inconsistent.

On the other hand, maybe we're fine to use (≥) in those places too if swap is reducible enough.

I can see swap on the operation but not on the relation. OTOH, filter.is_bounded uses (≤) and (≥) (I'm going to reformulate some theorems there using is_directed).

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 31, 2022
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 1, 2022
@fpvandoorn
Copy link
Member

This seems like a clear improvement. If there are any swap (≤) in the co[ntra]variant classes, then I think those should be changed too. But as Yury said, I think those are also applied to the operation.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 4, 2022
bors bot pushed a commit that referenced this pull request Jun 4, 2022
@bors
Copy link

bors bot commented Jun 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(order/directed): use (≥) instead of swap (≤) [Merged by Bors] - refactor(order/directed): use (≥) instead of swap (≤) Jun 4, 2022
@bors bors bot closed this Jun 4, 2022
@bors bors bot deleted the YK-directed-ge branch June 4, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants