[Merged by Bors] - feat(algebra/{lie/subalgebra,module/submodule/pointwise}): submodules and lie subalgebras form canonically ordered additive monoids under addition #14529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and lie subalgebras form canonically ordered additivve monoids under addition
eric-wieser
added
easy
eric-wieser
changed the title
eric-wieser
removed
the
easy
github-actions
bot
removed
the
awaiting-CI
fpvandoorn
reviewed
Jun 4, 2022
| local attribute [instance] canonically_ordered_add_monoid | ||
| ``` | ||
| -/ | ||
| def canonically_ordered_add_monoid : canonically_ordered_add_monoid (submodule R M) := |
There was a problem hiding this comment.
make reducible (see reducible non-instance library note)
There was a problem hiding this comment.
I'm not sure I agree; I thought @[reduclble] foo was for when we have instance : X := foo, not for when we have local attribute [instance] foo.
There was a problem hiding this comment.
At any rate, the follow-up PR will make this moot.
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
1 task
Done in #14553 |
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 4, 2022
… and lie subalgebras form canonically ordered additive monoids under addition (#14529) We can't actually make these instances because they result in loops for `simp`. The `le_iff_exists_sup` lemma is probably not very useful for much beyond these new instances, but it matches `le_iff_exists_add`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
tomaz1502
pushed a commit
that referenced
this pull request
Jun 5, 2022
… and lie subalgebras form canonically ordered additive monoids under addition (#14529) We can't actually make these instances because they result in loops for `simp`. The `le_iff_exists_sup` lemma is probably not very useful for much beyond these new instances, but it matches `le_iff_exists_add`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't actually make these instances because they result in loops for
simp.The
le_iff_exists_suplemma is probably not very useful for much beyond these new instances, but it matchesle_iff_exists_add.