Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(data/finset/nat_antidiagonal): state lemmas with cons instead of insert #14533

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jun 3, 2022

This puts less of a burden on the caller rewriting in the forward direction, as they don't have to prove obvious things about membership when evaluating sums.

Since this adds the missing finset.map_cons, a number of uses of multiset.map_cons now need qualified names.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 3, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 3, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense as a follow up to mine.

@urkud
Copy link
Member

urkud commented Jun 9, 2022

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 9, 2022
bors bot pushed a commit that referenced this pull request Jun 9, 2022
…d of insert (#14533)

This puts less of a burden on the caller rewriting in the forward direction, as they don't have to prove obvious things about membership when evaluating sums.

Since this adds the missing `finset.map_cons`, a number of uses of `multiset.map_cons` now need qualified names.
@bors
Copy link

bors bot commented Jun 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/finset/nat_antidiagonal): state lemmas with cons instead of insert [Merged by Bors] - refactor(data/finset/nat_antidiagonal): state lemmas with cons instead of insert Jun 9, 2022
@bors bors bot closed this Jun 9, 2022
@bors bors bot deleted the eric-wieser/antidiagonal-cons branch June 9, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants