Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(topology/vector_bundle): split file #14535

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - refactor(topology/vector_bundle): split file #14535

wants to merge 4 commits into from

Conversation

fpvandoorn
Copy link
Member

Also:

  • Rename pullback -> topological_vector_bundle.pullback
  • Use delta_instance instead of local attribute [reducible]
  • Change module doc
  • Remove transitive import

Open in Gitpod

@fpvandoorn fpvandoorn added the awaiting-review The author would like community review of the PR label Jun 3, 2022
@fpvandoorn fpvandoorn mentioned this pull request Jun 3, 2022
Closed
2 tasks
@fpvandoorn fpvandoorn requested a review from sgouezel June 4, 2022 10:27
@sgouezel
Copy link
Collaborator

sgouezel commented Jun 4, 2022

bors r+
It's pretty hard to check a PR that does both splitting and changing content, but I'll trust you on this one (and the splitting is definitely a good move).

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 4, 2022
bors bot pushed a commit that referenced this pull request Jun 4, 2022
@fpvandoorn
refactor(topology/vector_bundle): split file (#14535)
93fb534 
Also:

* Rename `pullback` -> `topological_vector_bundle.pullback`
* Use `delta_instance` instead of `local attribute [reducible]`
* Change module doc
* Remove transitive import
@bors
Copy link

bors bot commented Jun 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/vector_bundle): split file [Merged by Bors] - refactor(topology/vector_bundle): split file Jun 4, 2022
@bors bors bot closed this Jun 4, 2022
@bors bors bot deleted the split-vector-bundle branch June 4, 2022 19:43
tomaz1502 pushed a commit that referenced this pull request Jun 5, 2022
@fpvandoorn @tomaz1502
refactor(topology/vector_bundle): split file (#14535)
2442742 
Also:

* Rename `pullback` -> `topological_vector_bundle.pullback`
* Use `delta_instance` instead of `local attribute [reducible]`
* Change module doc
* Remove transitive import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpvandoorn @sgouezel