Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(number_theory/cyclotomic/primitive_roots): generalize finrank lemma #14550

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(number_theory/cyclotomic/primitive_roots): generalize finrank lemma #14550

wants to merge 9 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Jun 4, 2022 •
edited
Loading

We generalize certain results from fields to domains.

Open in Gitpod

@riccardobrasca riccardobrasca added the WIP Work in progress label Jun 4, 2022
@ericrbg ericrbg changed the title generalize docs#is_cyclotomic_extension.finrank feat(number_theory/cyclotomic/primitive_roots): generalize finrank lemma Jun 6, 2022
@ericrbg ericrbg added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 6, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 7, 2022
@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 8, 2022
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 14, 2022
bors bot pushed a commit that referenced this pull request Jun 14, 2022
@riccardobrasca @ericrbg
feat(number_theory/cyclotomic/primitive_roots): generalize finrank le…
7f9a7af 
…mma (#14550)

We generalize certain results from fields to domains.



Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com>
@bors
Copy link

bors bot commented Jun 15, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 15, 2022
@riccardobrasca @ericrbg
feat(number_theory/cyclotomic/primitive_roots): generalize finrank le…
b4b816c 
…mma (#14550)

We generalize certain results from fields to domains.



Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com>
@bors
Copy link

bors bot commented Jun 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/cyclotomic/primitive_roots): generalize finrank lemma [Merged by Bors] - feat(number_theory/cyclotomic/primitive_roots): generalize finrank lemma Jun 15, 2022
@bors bors bot closed this Jun 15, 2022
@bors bors bot deleted the RB/is_cycl_gen_pb branch June 15, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riccardobrasca @robertylewis @ericrbg