[Merged by Bors] - feat(logic/equiv/basic): two empty types are equivalent; remove various redundant lemmas #14604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
awaiting-review
1 task
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Jun 8, 2022
eric-wieser
approved these changes
Jun 8, 2022
eric-wieser
reviewed
Jun 8, 2022
eric-wieser
reviewed
Jun 8, 2022
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
vihdzp
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
…us redundant lemmas (#14604) We prove `equiv_of_is_empty`, which states two empty types are equivalent. This allows us to remove various redundant lemmas. We keep `empty_equiv_empty` and `empty_equiv_pempty` as these specific instantiations of that lemma are widely used.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2022
…ique` types (#14605) This PR does various simple and highly related things: - Rename `equiv_of_unique_of_unique` to `equiv_of_unique` and make its arguments explicit, in order to match the lemma `equiv_of_empty` added in #14604. - Rename `equiv_punit_of_unique` to `equiv_punit` and make its argument explicit to match `equiv_pempty`. - Fix their docstrings (which talked about a `subsingleton` type instead of a `unique` one). - Move them much earlier in the file, together with the lemmas on empty types. - Golf `prop_equiv_punit`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prove
equiv_of_is_empty, which states two empty types are equivalent. This allows us to remove various redundant lemmas.We keep
empty_equiv_emptyandempty_equiv_pemptyas these specific instantiations of that lemma are widely used.