Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/seminorm): removed unnecessary norm_one_class arguments #14614

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(analysis/seminorm): removed unnecessary norm_one_class arguments #14614

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Jun 8, 2022
@eric-wieser eric-wieser requested a review from mcdoll June 8, 2022 08:57
@eric-wieser eric-wieser mentioned this pull request Jun 8, 2022
Closed
1 task
mcdoll
mcdoll approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@mcdoll mcdoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a huge fan of unnamed sections, but since it is only 30 lines long I think it is fine.

@eric-wieser
Copy link
Member Author

In this case the unnamed section is just "I'm going to introduce a p variable"

@urkud
Copy link
Member

urkud commented Jun 9, 2022

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 9, 2022
bors bot pushed a commit that referenced this pull request Jun 9, 2022
@eric-wieser
feat(analysis/seminorm): removed unnecessary norm_one_class argumen…
cde6e63 
…ts (#14614)
@bors
Copy link

bors bot commented Jun 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/seminorm): removed unnecessary norm_one_class arguments [Merged by Bors] - feat(analysis/seminorm): removed unnecessary norm_one_class arguments Jun 9, 2022
@bors bors bot closed this Jun 9, 2022
@bors bors bot deleted the eric-wieser/seminorm.neg branch June 9, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdoll mcdoll mcdoll approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @urkud @mcdoll