[Merged by Bors] - doc(tactic/congr): add relationship to move_add in ac_change
#14618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
Closed
1 task
bors bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
…ands (#13483) This PR introduces a tactic for moving summands of an expression. Individual terms can be named, also using pattern-matching, and moved to the beginning or to the end of the sum. #14228 shows a sample of golfing and usage of `move_add`, and the [diff](aa_sort...adomani_move_add_random_golf) between them. #14618 contains the doc-string update to `ac_change`: I moved it to a separate PR to save CI cycles. See `compute_degree` in #14040 for a related tactic to compute `degree`s and `nat_degree`s of polynomials that uses `move_add`. ~~A future PR may add support for sorting also factors of a product, though this may happen after the switch to Lean4.~~ Co-authored-by: Arthur Paulino <arthurleonardo.ap@gmail.com>
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
adomani
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2022
) This follows #13483, where `move_add` is defined. A big reason for splitting these few lines off the main PR is that they are not in a leaf of the import hierarchy: this hopefully saves lots of CI time, when doing trivial changes to the main PR. This PR should be merged, if #13483 gets merged: they come in a package! Co-authored-by: Arthur Paulino <arthurleonardo.ap@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
move_add in ac_changemove_add in ac_change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #13483, where
move_addis defined.A big reason for splitting these few lines off the main PR is that they are not in a leaf of the import hierarchy: this hopefully saves lots of CI time, when doing trivial changes to the main PR.
This PR should be merged, if #13483 gets merged: they come in a package!
Co-authored-by: Arthur Paulino arthurleonardo.ap@gmail.com
move_addis defined