Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set_theory/ordinal/basic): tweak theorems on order type of empty relation #14650

Closed
wants to merge 7 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jun 9, 2022

We move the theorems on the order type of an empty relation much earlier, and golf them. We also remove other redundant theorems.

zero_eq_type_empty is made redundant by type_eq_zero_of_empty, while zero_eq_lift_type_empty is made redundant by the former lemma and lift_zero.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jun 9, 2022
@vihdzp vihdzp changed the title feat(set_theory/ordinal/basic): order type of empty relation is 0 feat(set_theory/ordinal/basic): tweak theorems on order type of empty relation Jun 9, 2022
@eric-wieser
Copy link
Member

bors d+

Thanks!

@eric-wieser eric-wieser added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 9, 2022
@bors
Copy link

bors bot commented Jun 9, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 9, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Jun 10, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 10, 2022
… relation (#14650)

We move the theorems on the order type of an empty relation much earlier, and golf them. We also remove other redundant theorems.

`zero_eq_type_empty` is made redundant by `type_eq_zero_of_empty`, while `zero_eq_lift_type_empty`  is made redundant by the former lemma and `lift_zero`.
@bors
Copy link

bors bot commented Jun 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/ordinal/basic): tweak theorems on order type of empty relation [Merged by Bors] - feat(set_theory/ordinal/basic): tweak theorems on order type of empty relation Jun 10, 2022
@bors bors bot closed this Jun 10, 2022
@bors bors bot deleted the rel_iso_empty' branch June 10, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants