[Merged by Bors] - refactor(logic/is_empty): tag is_empty.forall_iff and is_empty.exists_iff as simp
#14660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
awaiting-review
vihdzp
changed the title
forall_pempty and exists_pempty, mark forall_iff and exists_iff as simpforall_iff and exists_iff as simp
vihdzp
changed the title
forall_iff and exists_iff as simpforall_iff and exists_iff as simp
This reverts commit ab640f8.
github-actions
bot
removed
the
awaiting-CI
Is this your valuation or |
eric-wieser
added
the
merge-conflict
|
It's both my valuation and I'd give the extra justification for removing these lemmas that building much API on |
vihdzp
removed
the
merge-conflict
kmill
reviewed
Jul 8, 2022
kmill
changed the title
forall_iff and exists_iff as simpis_empty.forall_iff and is_empty.exists_iff as simp
|
Looks good to me, thanks! Let's just have one last CI check before you merge. bors d=vihdzp |
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
vihdzp
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
…sts_iff` as `simp` (#14660) We tag the lemmas `forall_iff` and `exists_iff` on empty types as `simp`. We remove `forall_pempty`, `exists_pempty`, `forall_false_left`, and `exists_false_left` due to being redundant.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
is_empty.forall_iff and is_empty.exists_iff as simpis_empty.forall_iff and is_empty.exists_iff as simp
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
…sts_iff` as `simp` (#14660) We tag the lemmas `forall_iff` and `exists_iff` on empty types as `simp`. We remove `forall_pempty`, `exists_pempty`, `forall_false_left`, and `exists_false_left` due to being redundant.
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tag the lemmas
forall_iffandexists_iffon empty types assimp. We removeforall_pempty,exists_pempty,forall_false_left, andexists_false_leftdue to being redundant.