[Merged by Bors] - refactor(data/option/defs): Swap arguments to option.elim
#14681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
eric-wieser
approved these changes
Jun 13, 2022
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
Did I not do that already? |
|
Well your PR description doesn't mention it! |
|
Fair. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Make `option.elim` a non-dependent version of `option.rec` rather than a non-dependent version of `option.rec_on`. Same for `option.melim`. This replaces `option.cons`, and brings `option.elim` in line with `nat.elim`, `sum.elim`, and `iff.elim`. It addresses the TODO comment added in 22c4291.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
option.elimoption.elim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
option.elima non-dependent version ofoption.recrather than a non-dependent version ofoption.rec_on. Same foroption.melim.This replaces
option.cons, and bringsoption.elimin line withnat.elim,sum.elim, andiff.elim.It addresses the TODO comment added in 22c4291.
Zulip