Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(set_theory/game/*): fix theorem names #14685

Closed
wants to merge 7 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jun 11, 2022

Some theorems about exists had forall in the name, other theorems about swapped or used le and lf instead of ge and gf.

We also golf le_of_forall_lt.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jun 11, 2022
@vihdzp vihdzp requested a review from alreadydone June 11, 2022 18:46
Copy link
Collaborator

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Strangely "build mathlib" failed without showing error messages...

@alreadydone
Copy link
Collaborator

alreadydone commented Jun 11, 2022

Interesting: build succeeded but "push release to azure" failed now CI passed

@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 14, 2022
@robertylewis
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 14, 2022
bors bot pushed a commit that referenced this pull request Jun 14, 2022
Some theorems about `exists` had `forall` in the name, other theorems about swapped `≤` or `⧏` used `le` and `lf` instead of `ge` and `gf`.

We also golf `le_of_forall_lt`.
@bors
Copy link

bors bot commented Jun 14, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 15, 2022
Some theorems about `exists` had `forall` in the name, other theorems about swapped `≤` or `⧏` used `le` and `lf` instead of `ge` and `gf`.

We also golf `le_of_forall_lt`.
@bors
Copy link

bors bot commented Jun 15, 2022

Build failed (retrying...):

@bors
Copy link

bors bot commented Jun 15, 2022

Canceled.

@alreadydone
Copy link
Collaborator

CI has now passed and I think it's time to request another bors r+ or bors merge.

@eric-wieser
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jun 15, 2022
Some theorems about `exists` had `forall` in the name, other theorems about swapped `≤` or `⧏` used `le` and `lf` instead of `ge` and `gf`.

We also golf `le_of_forall_lt`.



Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
@bors
Copy link

bors bot commented Jun 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(set_theory/game/*): fix theorem names [Merged by Bors] - refactor(set_theory/game/*): fix theorem names Jun 15, 2022
@bors bors bot closed this Jun 15, 2022
@bors bors bot deleted the pgame_fix_names branch June 15, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants