[Merged by Bors] - feat(linear_algebra/*): add lemma linear_independent.finite_of_is_noetherian
#14714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocfnash
added
awaiting-review
…etherian` This replaces `fintype_of_is_noetherian_linear_independent` which gave the same conclusion except demanded `strong_rank_condition R` instead of just `nontrivial R`. Also some other minor gaps filled.
ocfnash
force-pushed
the
ocfnash/linear_indep_finite
branch
from
f05ad01
to
d7702c9
Compare
1 task
src/order/sup_indep.lean
Outdated
| refine (supr_mono $ λ i, _).trans (supr_comp_le _ f), | ||
| exact supr_const_mono hf.ne, | ||
| end | ||
|
|
||
| lemma independent.comp' |
There was a problem hiding this comment.
The names independent.comp and independent.comp' are not great. It's not easy to understand from names that composition is not on the same side. Maybe independent.comp_inj and independent.of_comp_surj or something? It's not really clearer...
There was a problem hiding this comment.
I agree but I'm not sure about comp_inj and of_comp_surj either.
github-actions
bot
removed
the
awaiting-CI
jcommelin
reviewed
Jun 22, 2022
kmill
reviewed
Jun 22, 2022
eric-wieser
reviewed
Jun 26, 2022
eric-wieser
reviewed
Jun 26, 2022
…ndent_span_singleton` Suggestion of CR
eric-wieser
reviewed
Jun 27, 2022
…e.well_founded.finite_of_independent`
eric-wieser
reviewed
Jun 27, 2022
eric-wieser
reviewed
Jun 27, 2022
eric-wieser
reviewed
Jun 27, 2022
eric-wieser
reviewed
Jun 27, 2022
|
Thanks bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…etherian` (#14714) This replaces `fintype_of_is_noetherian_linear_independent` which gave the same conclusion except demanded `strong_rank_condition R` instead of just `nontrivial R`. Also some other minor gaps filled.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…etherian` (#14714) This replaces `fintype_of_is_noetherian_linear_independent` which gave the same conclusion except demanded `strong_rank_condition R` instead of just `nontrivial R`. Also some other minor gaps filled.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
linear_independent.finite_of_is_noetherianlinear_independent.finite_of_is_noetherian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
fintype_of_is_noetherian_linear_independentwhich gave the sameconclusion except demanded
strong_rank_condition Rinstead of justnontrivial R.Also some other minor gaps filled.