Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(geometry/manifold/diffeomorph): some additions needed for smooth vector bundles #14738

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(geometry/manifold/diffeomorph): some additions needed for smooth vector bundles #14738

wants to merge 2 commits into from

Conversation

fpvandoorn
Copy link
Member

  • Define diffeomorph.prod_comm, diffeomorph.prod_congr, diffeomorph.prod_assoc
  • Prove cont_mdiff_on.comp_cont_mdiff
  • In fiber_bundle, define some lemmas for local_triv_at that were already there for local_triv
  • Yes, this PR does a couple different things, but it is still very small
  • This is part of [WIP] define smooth fiber bundles #14412

Open in Gitpod

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 14, 2022
@fpvandoorn fpvandoorn requested a review from sgouezel June 14, 2022 16:19
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 15, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Jun 20, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 20, 2022
bors bot pushed a commit that referenced this pull request Jun 20, 2022
@fpvandoorn
feat(geometry/manifold/diffeomorph): some additions needed for smooth…
804afcb 
… vector bundles (#14738)

* Define `diffeomorph.prod_comm`, `diffeomorph.prod_congr`, `diffeomorph.prod_assoc`
* Prove `cont_mdiff_on.comp_cont_mdiff`
* In `fiber_bundle`, define some lemmas for `local_triv_at` that were already there for `local_triv`
* Yes, this PR does a couple different things, but it is still very small
* This is part of #14412
@bors
Copy link

bors bot commented Jun 20, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(geometry/manifold/diffeomorph): some additions needed for smooth vector bundles [Merged by Bors] - feat(geometry/manifold/diffeomorph): some additions needed for smooth vector bundles Jun 20, 2022
@bors bors bot closed this Jun 20, 2022
@bors bors bot deleted the manifold_additions branch June 20, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpvandoorn @ocfnash