Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(ring_theory/valuation/valuation_subring): define principal unit group of valuation subring and provide basic API #14742
[Merged by Bors] - feat(ring_theory/valuation/valuation_subring): define principal unit group of valuation subring and provide basic API #14742
Changes from 24 commits
001e35b
ed69042
4145d1b
6ea8652
8b220a2
3eb2447
ebe56c2
4df7870
2f3d6f8
d7aefdc
b2c52cd
297233a
e9c8d41
07568c8
825e748
89e8d56
cfe9e99
819ce7d
5ff08ca
86c234d
08fd5f6
0c82af5
6bcf5cd
3e61008
29234ee
765da91
9228e46
5687893
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing