New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tactic/core): derive handler for simple instances #1475
Conversation
This is a good idea but the name is wrong. It is very much inline with Haskell's |
I changed the PR title and doc string to remove the word "algebraic." |
Good :) Why do you make the definition of the instance an abbreviation? |
Oh, no good reason. I don't know what the default values for |
I would use |
Changed to use |
Co-Authored-By: Johan Commelin <johan@commelin.net>
…mmunity#1475) * feat(tactic/core): derive handler for simple algebraic instances * change comment * use mk_definition * Update src/tactic/core.lean Co-Authored-By: Johan Commelin <johan@commelin.net>
https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/deriving.20instances
This is a simple derive handler for adding instances that can be found just by unfolding a new definition.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list