[Merged by Bors] - refactor(category_theory): custom structure for full_subcategory #14767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
approved these changes
Jul 27, 2022
|
✌️ TwoFX can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
TwoFX
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
) Full subcategories are now a custom structure rather than the usual subtype. The advantage of this is that we don't have to fight the `simp`-normal form of subtypes, as the coercion does more harm than good for full subcategories. We saw a similar refactor for discrete categories, and in both cases, erring on the side of explicitness seems to pay off.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
) Full subcategories are now a custom structure rather than the usual subtype. The advantage of this is that we don't have to fight the `simp`-normal form of subtypes, as the coercion does more harm than good for full subcategories. We saw a similar refactor for discrete categories, and in both cases, erring on the side of explicitness seems to pay off.
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
) Full subcategories are now a custom structure rather than the usual subtype. The advantage of this is that we don't have to fight the `simp`-normal form of subtypes, as the coercion does more harm than good for full subcategories. We saw a similar refactor for discrete categories, and in both cases, erring on the side of explicitness seems to pay off.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full subcategories are now a custom structure rather than the usual subtype. The advantage of this is that we don't have to fight the
simp-normal form of subtypes, as the coercion does more harm than good for full subcategories.We saw a similar refactor for discrete categories, and in both cases, erring on the side of explicitness seems to pay off.
Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/Redefining.20Sheaves