Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(counterexamples/sorgenfrey_line): new file #14820

Closed
wants to merge 29 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 19, 2022

Define the Sorgenfrey line and prove that it is a normal topological space but its product with itself is not a normal topological space.


Should it go to counterexamples/ or src/topology/instances?

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 19, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 19, 2022
counterexamples/sorgenfrey_line.lean Outdated Show resolved Hide resolved
counterexamples/sorgenfrey_line.lean Show resolved Hide resolved
counterexamples/sorgenfrey_line.lean Outdated Show resolved Hide resolved
counterexamples/sorgenfrey_line.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 24, 2022
@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 5, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@[derive [conditionally_complete_linear_order, linear_ordered_field, archimedean]]
def sorgenfrey_line : Type := ℝ

notation `ℝₗ` := sorgenfrey_line
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local notation? Maybe someone will need to import this file someday.

(Ici_prod_eq x).symm ▸ (is_clopen_Ici _).prod (is_clopen_Ici _)

lemma is_closed_of_subset_antidiagonal {s : set (ℝₗ × ℝₗ)} {c : ℝₗ}
(hs : ∀ x ∈ s, (x : _).1 + x.2 = c) : is_closed s :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fill in the underscore to help the reader?

lemma is_clopen_Ici_prod (x : ℝₗ × ℝₗ) : is_clopen (Ici x) :=
(Ici_prod_eq x).symm ▸ (is_clopen_Ici _).prod (is_clopen_Ici _)

lemma is_closed_of_subset_antidiagonal {s : set (ℝₗ × ℝₗ)} {c : ℝₗ}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a docstring to this lemma, because it is both important and striking?

@bors
Copy link

bors bot commented Sep 9, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 9, 2022
@urkud
Copy link
Member Author

urkud commented Sep 10, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 10, 2022
bors bot pushed a commit that referenced this pull request Sep 10, 2022
Define the Sorgenfrey line and prove that it is a normal topological space but its product with itself is not a normal topological space.
@bors
Copy link

bors bot commented Sep 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(counterexamples/sorgenfrey_line): new file [Merged by Bors] - feat(counterexamples/sorgenfrey_line): new file Sep 10, 2022
@bors bors bot closed this Sep 10, 2022
@bors bors bot deleted the YK-sorgenfrey branch September 10, 2022 03:25
bottine pushed a commit that referenced this pull request Sep 13, 2022
Define the Sorgenfrey line and prove that it is a normal topological space but its product with itself is not a normal topological space.
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
Define the Sorgenfrey line and prove that it is a normal topological space but its product with itself is not a normal topological space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants