Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat({algebra/big_operators/basic,data/rat/cast}): Missing cast lemmas #14824

Closed
wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jun 19, 2022

rat.cast_sum, rat.cast_prod and nat, int lemmas about multiset and list big operators.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Jun 19, 2022
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

It would be great to have the multiset and list versions too

@bors
Copy link

bors bot commented Jun 21, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 21, 2022
@eric-wieser
Copy link
Member

The new additions look good, don't forget to update the title and PR description

@YaelDillies YaelDillies changed the title feat(data/rat/cast): Missing cast lemmas feat({algebra/big_operators/basic,data/rat/cast}): Missing cast lemmas Jun 22, 2022
@YaelDillies
Copy link
Collaborator Author

Done!

bors merge

bors bot pushed a commit that referenced this pull request Jun 22, 2022
#14824)

`rat.cast_sum`, `rat.cast_prod` and `nat`, `int` lemmas about `multiset` and `list` big operators.
@bors
Copy link

bors bot commented Jun 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat({algebra/big_operators/basic,data/rat/cast}): Missing cast lemmas [Merged by Bors] - feat({algebra/big_operators/basic,data/rat/cast}): Missing cast lemmas Jun 22, 2022
@bors bors bot closed this Jun 22, 2022
@bors bors bot deleted the rat_cast_sum branch June 22, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants