Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/convex/strict_convex_space): isometries of strictly convex spaces are affine #14837

Closed
wants to merge 8 commits into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Jun 20, 2022

Add the result that isometries of (affine spaces for) real normed
spaces with strictly convex codomain are affine isometries. In
particular, this applies to isometries of Euclidean spaces (we already
have the instance that real inner product spaces are uniformly convex
and thus strictly convex). Strict convexity means the surjectivity
requirement of Mazur-Ulam can be avoided.


Open in Gitpod

…vex spaces are affine

Add the result that isometries of (affine spaces for) real normed
spaces with strictly convex codomain are affine isometries.  In
particular, this applies to isometries of Euclidean spaces (we already
have the instance that real inner product spaces are uniformly convex
and thus strictly convex).  Strict convexity means the surjectivity
requirement of Mazur-Ulam can be avoided.
@jsm28 jsm28 added the awaiting-review The author would like community review of the PR label Jun 20, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proofs look golfable, but the rest looks very fine!

src/analysis/convex/strict_convex_space.lean Outdated Show resolved Hide resolved
src/analysis/convex/strict_convex_space.lean Outdated Show resolved Hide resolved
@jsm28
Copy link
Collaborator Author

jsm28 commented Jun 20, 2022

Golfing of proofs is welcome (the intermediate lemmas aren't really intended to be of independent use, and follow immediately from the final results, so if any of those lemmas become redundant after golfing it would be reasonable to remove them).

@urkud
Copy link
Member

urkud commented Jun 21, 2022

I would write the main proof using affine_map.of_map_midpoint and the following lemma: if dist x y = r * dist x z and dist y z = (1 - r) * dist x z, then y is the convex combination of x and z with weights (1 - r) and r (proof: since dist x y + dist y z = dist x z, we know that y belongs to the segment; the weights can be found from either eqn).
Possibly, it makes sens to add a version of this lemma with r and r - 1 instead of r and 1 - r too.

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 21, 2022
@jsm28
Copy link
Collaborator Author

jsm28 commented Jun 21, 2022

I've reworked the proof using affine_map.of_map_midpoint and the suggested lemma (removing all the other intermediate lemmas and definitions), feel free to golf any of the new proofs.

@jsm28 jsm28 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 21, 2022
@urkud
Copy link
Member

urkud commented Jun 22, 2022

Reformulated using line_map, golfed.

@urkud
Copy link
Member

urkud commented Jun 23, 2022

Please mention this in the module docstring. Otherwise LGTM.
bors d+

@bors
Copy link

bors bot commented Jun 23, 2022

✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 23, 2022
@jsm28
Copy link
Collaborator Author

jsm28 commented Jun 23, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 23, 2022
…vex spaces are affine (#14837)

Add the result that isometries of (affine spaces for) real normed
spaces with strictly convex codomain are affine isometries.  In
particular, this applies to isometries of Euclidean spaces (we already
have the instance that real inner product spaces are uniformly convex
and thus strictly convex).  Strict convexity means the surjectivity
requirement of Mazur-Ulam can be avoided.





Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Jun 23, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/convex/strict_convex_space): isometries of strictly convex spaces are affine [Merged by Bors] - feat(analysis/convex/strict_convex_space): isometries of strictly convex spaces are affine Jun 23, 2022
@bors bors bot closed this Jun 23, 2022
@bors bors bot deleted the jsm28/strict_convex_isometry branch June 23, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants