[Merged by Bors] - golf(data/polynomial): factorization into linear factors when #roots=degree #14862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alreadydone
added
awaiting-review
|
Thanks 🎉 If CI passes, please remove the label bors d+ |
|
✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
alreadydone
changed the title
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
…degree (#14862) + Golf the proofs of `prod_multiset_X_sub_C_of_monic_of_roots_card_eq` and `C_leading_coeff_mul_prod_multiset_X_sub_C` and move them from *splitting_field.lean* to *ring_division.lean*; instead of using the former to deduce the latter as is currently done in mathlib, we prove the latter first and deduce the former easily. Remove the less general auxiliary, `private` `_of_field` versions. + Move `pairwise_coprime_X_sub` from *field_division.lean* to *ring_division.lean*. Rename it to `pairwise_coprime_X_sub_C` to conform with existing convention. Golf its proof using the more general new lemma `is_coprime_X_sub_C_of_is_unit_sub`. + Golf `monic.irreducible_of_irreducible_map`, but it's essentially the same proof.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golf the proofs of
prod_multiset_X_sub_C_of_monic_of_roots_card_eqandC_leading_coeff_mul_prod_multiset_X_sub_Cand move them from splitting_field.lean to ring_division.lean; instead of using the former to deduce the latter as is currently done in mathlib, we prove the latter first and deduce the former easily. Remove the less general auxiliary,private_of_fieldversions.Move
pairwise_coprime_X_subfrom field_division.lean to ring_division.lean. Rename it topairwise_coprime_X_sub_Cto conform with existing convention. Golf its proof using the more general new lemmais_coprime_X_sub_C_of_is_unit_sub.Golf
monic.irreducible_of_irreducible_map, but it's essentially the same proof.