Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(data/nat/parity): nat.even_succ -> nat.even_add_one #14917

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - refactor(data/nat/parity): nat.even_succ -> nat.even_add_one #14917

wants to merge 5 commits into from

Conversation

BoltonBailey
Copy link
Collaborator

@BoltonBailey BoltonBailey commented Jun 24, 2022 •
edited by kmill
Loading

Change nat.even_succ to be analogous to int.even_add_one.

Open in Gitpod

@BoltonBailey BoltonBailey mentioned this pull request Jun 24, 2022
Open
2 tasks
@BoltonBailey BoltonBailey added awaiting-CI The author would like to see what CI has to say before doing more work. easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 24, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 24, 2022
@BoltonBailey BoltonBailey removed the easy < 20s of review time. See the lifecycle page for guidelines. label Jun 24, 2022
@BoltonBailey BoltonBailey added the awaiting-review The author would like community review of the PR label Jun 29, 2022
@kmill
Copy link
Collaborator

kmill commented Jul 1, 2022

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 1, 2022
bors bot pushed a commit that referenced this pull request Jul 1, 2022
@BoltonBailey
feat(data/nat/parity): even_add_one (#14917)
2c9261b 
Adds a short lemma for convenience, analogous to `int.even_add_one`.
@bors
Copy link

bors bot commented Jul 1, 2022

Build failed (retrying...):

@kmill
Copy link
Collaborator

kmill commented Jul 1, 2022

bors r-

There's some conflict somewhere with other PRs on the bors queue. I'm going to remove this for now, then once they're done let's merge master and try again.

@bors
Copy link

bors bot commented Jul 1, 2022

Canceled.

@kmill kmill added awaiting-review The author would like community review of the PR and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Jul 1, 2022
@BoltonBailey
Copy link
Collaborator Author

@kmill

@kmill kmill changed the title feat(data/nat/parity): even_add_one refactor(data/nat/parity): nat.even_succ -> nat.even_add_one Jul 4, 2022
@kmill
Copy link
Collaborator

kmill commented Jul 4, 2022

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 4, 2022
bors bot pushed a commit that referenced this pull request Jul 4, 2022
@BoltonBailey
refactor(data/nat/parity): nat.even_succ -> nat.even_add_one (#14917
051dffa 
)

Change `nat.even_succ` to be analogous to `int.even_add_one`.
@bors
Copy link

bors bot commented Jul 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/nat/parity): nat.even_succ -> nat.even_add_one [Merged by Bors] - refactor(data/nat/parity): nat.even_succ -> nat.even_add_one Jul 4, 2022
@bors bors bot closed this Jul 4, 2022
@bors bors bot deleted the BoltonBailey/nat-parity-add-one branch July 4, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill left review comments

@vihdzp vihdzp vihdzp left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BoltonBailey @kmill @vihdzp