New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(order/complete_lattice): tweak simp
lemmas
#14918
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
the
awaiting-review
The author would like community review of the PR
label
Jun 24, 2022
vihdzp
added
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Jun 25, 2022
mathlib-dependent-issues-bot
added
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
and removed
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
labels
Jun 25, 2022
This PR/issue depends on: |
Making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-CI
The author would like to see what CI has to say before doing more work.
awaiting-review
The author would like community review of the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks
Sup_range
,supr_of_empty'
,supr_of_empty
and their inf counterparts assimp
. Further, the redundantsupr_false
andinfi_false
are removed in favor ofsupr_of_empty
andinfi_of_empty
.Note that marking
Sup_range
assimp
means thatby simp [supr]
will loop. This affects a fewsimp
coercion lemmas, but once those are proven, this doesn't seem to cause trouble.nonempty_coe_sort
andis_empty_coe_sort
#14937