Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(order/complete_lattice): tweak simp lemmas #14918

Closed
wants to merge 13 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jun 24, 2022

This PR marks Sup_range, supr_of_empty', supr_of_empty and their inf counterparts as simp. Further, the redundant supr_false and infi_false are removed in favor of supr_of_empty and infi_of_empty.

Note that marking Sup_range as simp means that by simp [supr] will loop. This affects a few simp coercion lemmas, but once those are proven, this doesn't seem to cause trouble.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jun 24, 2022
@vihdzp vihdzp added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 25, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jun 25, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

@vihdzp
Copy link
Collaborator Author

vihdzp commented Jul 1, 2022

Making Sup_range a simp lemma was a bad idea, actually. Will re-do this with only the supr_empty change.

@vihdzp vihdzp closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants