Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/boolean_algebra): Interaction of disjointness and complements #14925

Closed
wants to merge 12 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jun 24, 2022

Prove disjoint x yᶜ ↔ x ≤ y and similar, transfer those results to set.

Lemma renames

  • subset_compl_iff_disjointsubset_compl_iff_disjoint_right
  • set.subset_compl_iff_disjointset.subset_compl_iff_disjoint_right
  • disjoint_iff_le_compl_leftle_compl_iff_disjoint_left
  • disjoint_iff_le_compl_rightle_compl_iff_disjoint_right

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 24, 2022
theorem subset_compl_comm {s t : set α} : s ⊆ tᶜ ↔ t ⊆ sᶜ :=
forall_congr $ λ a, imp_not_comm

-- TODO@Yaël: This duplicates `subset_compl_iff_disjoint_right`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started replacing its uses, but I stumbled upon a bunch of fixable things in the topology library, so I singled them out to #14950.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 26, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 27, 2022
bors bot pushed a commit that referenced this pull request Jun 27, 2022
…nts (#14925)

Prove `disjoint x yᶜ ↔ x ≤ y` and similar, transfer those results to `set`.

Lemma renames
* `subset_compl_iff_disjoint` → `subset_compl_iff_disjoint_right`
* `set.subset_compl_iff_disjoint` → `set.subset_compl_iff_disjoint_right`
* `disjoint_iff_le_compl_left` → `le_compl_iff_disjoint_left`
* `disjoint_iff_le_compl_right` → `le_compl_iff_disjoint_right`
@bors
Copy link

bors bot commented Jun 27, 2022

Build failed:

@jcommelin
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jun 28, 2022
…nts (#14925)

Prove `disjoint x yᶜ ↔ x ≤ y` and similar, transfer those results to `set`.

Lemma renames
* `subset_compl_iff_disjoint` → `subset_compl_iff_disjoint_right`
* `set.subset_compl_iff_disjoint` → `set.subset_compl_iff_disjoint_right`
* `disjoint_iff_le_compl_left` → `le_compl_iff_disjoint_left`
* `disjoint_iff_le_compl_right` → `le_compl_iff_disjoint_right`
@bors
Copy link

bors bot commented Jun 28, 2022

Build failed:

@jcommelin
Copy link
Member

bors d+

bors merge

@bors
Copy link

bors bot commented Jun 28, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jun 28, 2022
bors bot pushed a commit that referenced this pull request Jun 28, 2022
…nts (#14925)

Prove `disjoint x yᶜ ↔ x ≤ y` and similar, transfer those results to `set`.

Lemma renames
* `subset_compl_iff_disjoint` → `subset_compl_iff_disjoint_right`
* `set.subset_compl_iff_disjoint` → `set.subset_compl_iff_disjoint_right`
* `disjoint_iff_le_compl_left` → `le_compl_iff_disjoint_left`
* `disjoint_iff_le_compl_right` → `le_compl_iff_disjoint_right`
@bors
Copy link

bors bot commented Jun 28, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 28, 2022
…nts (#14925)

Prove `disjoint x yᶜ ↔ x ≤ y` and similar, transfer those results to `set`.

Lemma renames
* `subset_compl_iff_disjoint` → `subset_compl_iff_disjoint_right`
* `set.subset_compl_iff_disjoint` → `set.subset_compl_iff_disjoint_right`
* `disjoint_iff_le_compl_left` → `le_compl_iff_disjoint_left`
* `disjoint_iff_le_compl_right` → `le_compl_iff_disjoint_right`
@bors
Copy link

bors bot commented Jun 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/boolean_algebra): Interaction of disjointness and complements [Merged by Bors] - feat(order/boolean_algebra): Interaction of disjointness and complements Jun 28, 2022
@bors bors bot closed this Jun 28, 2022
@bors bors bot deleted the subset_compl_iff_disjoint branch June 28, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants