feat(*): Upgrade to lean 3.44.0 #14930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
WIP
rwbarton
reviewed
Jun 25, 2022
eric-wieser
force-pushed
the
upgrade-to-lean-3.44.0
branch
from
835bda9
to
17d4d95
Compare
|
Closed in favor of #14984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
reflected ais now speltreflected _ a, as the argument was made explicit to resolve type resolution issues.optionis now flagged as not simp-normal bysimp_nf; this was already the case before, but the linter previously couldn't see it.simpseems to apply lemmas in a slightly different order now that it knows how to useifflemmas asdsimplemmas.dsimpandsimpnow applyset.mem_imageandset.mem_rangemore keenly than they used to.opposite.op_inj_iffshouldn't be proved until afteroppositeis irreducible (whereiff.rflno longer works as a proof), otherwisedsimpis tricked into unfolding the irreducibility which puts the goal state in a form where no further lemmas can apply.