[Merged by Bors] - feat(algebraic_geometry/morphisms): Basic framework for classes of morphisms between schemes #14944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erdOne
commented
Jun 25, 2022
erdOne
commented
erdOne
added
the
awaiting-review
erdOne
changed the title
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
…-community/mathlib into scheme_morphism_basic
jcommelin
reviewed
Jul 16, 2022
|
|
||
| /-- A morphism property is `stable_under_composition` if the base change of such a morphism | ||
| still falls in the class. -/ | ||
| def stable_under_base_change |
There was a problem hiding this comment.
I guess this should come with API that let's you apply/construct this using "a base change" instead of "the base change". Can be done in a future PR.
jcommelin
added
awaiting-author
erdOne
added
awaiting-review
jcommelin
reviewed
Jul 16, 2022
jcommelin
added
awaiting-author
erdOne
added
awaiting-review
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
…rphisms between schemes (#14944) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
…rphisms between schemes (#14944) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…rphisms between schemes (leanprover-community#14944) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…rphisms between schemes (#14944) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
…rphisms between schemes (#14944) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.