[Merged by Bors] - feat(algebraic_geometry): Restriction of morphisms onto open sets of the target #14972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erdOne
commented
Jun 26, 2022
erdOne
commented
erdOne
added
the
awaiting-review
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
…munity/mathlib into morphism_restrict
|
I made some formatting edits in a new branch. Mainly, I wouldn't indent after an equal sign or ≅, for example here, but others might have different opinion? Another change is in affine_basis_cover_is_basis whose statement is made more succinct. |
|
Thanks! |
|
Actually a recent commit by a maintainer does use indentation after =, so there's definite a different opinion, so feel free to revert those changes. |
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2022
…the target (#14972) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2022
…the target (#14972) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
…the target (#14972) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.