Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/minpoly): generalize statements about GCD domains #14979

Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - feat(field_theory/minpoly): generalize statements about GCD domains #14979

wants to merge 17 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Jun 26, 2022 •
edited

Currently, the statements about the minimal polynomial over a GCD domain R require the element to be in a K-algebra, where K is the fraction field of R. We remove this assumption.

From flt-regular.

Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 26, 2022
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 26, 2022
@riccardobrasca riccardobrasca mentioned this pull request Jun 26, 2022
Closed
1 task
@Vierkantor Vierkantor self-requested a review June 27, 2022 14:22
Vierkantor
Vierkantor reviewed Jun 27, 2022
View reviewed changes
src/ring_theory/polynomial/cyclotomic/basic.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 27, 2022
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 29, 2022
Vierkantor
Vierkantor approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/field_theory/minpoly.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 29, 2022

✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

riccardobrasca and others added 3 commits June 29, 2022 17:06
@riccardobrasca @Vierkantor
Update src/field_theory/minpoly.lean
db470b1 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@riccardobrasca
doc
c64e99f
@riccardobrasca
fix build
a936b96
@riccardobrasca
Copy link
Member Author

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 29, 2022
bors bot pushed a commit that referenced this pull request Jun 29, 2022
@riccardobrasca
feat(field_theory/minpoly): generalize statements about GCD domains (#…
71985dc 
…14979)

Currently, the statements about the minimal polynomial over a GCD domain `R` require the element to be in a `K`-algebra, where `K` is the fraction field of `R`. We remove this assumption.

From flt-regular.
@bors
Copy link

bors bot commented Jun 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/minpoly): generalize statements about GCD domains [Merged by Bors] - feat(field_theory/minpoly): generalize statements about GCD domains Jun 29, 2022
@bors bors bot closed this Jun 29, 2022
@bors bors bot deleted the RB/minpoly_gcd branch June 29, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riccardobrasca @Vierkantor