[Merged by Bors] - refactor(algebra/group_power): split ring lemmas into a separate file #15032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't actually stop `algebra.ring.basic` being imported into group_power.basic yet, but it makes it easier to make that change in future.
eric-wieser
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…#15032) This doesn't actually stop `algebra.ring.basic` being imported into `group_power.basic` yet, but it makes it easier to make that change in future. Two ~300 line files are also slightly easier to manage than one ~600 line file, and ring/add_group feels like a natural place to draw the line All lemmas have just been moved, and none have been renamed. Some lemmas have had their `R` variables renamed to `M` to better reflect that they apply to monoids with zero.
github-actions
bot
added
ready-to-merge
|
bors r- bors r+ (I edited the PR description) |
|
Canceled. |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…#15032) This doesn't actually stop `algebra.ring.basic` being imported into `group_power.basic` yet, but it makes it easier to make that change in future. Two ~300 line files are also slightly easier to manage than one ~600 line file, and ring/add_group feels like a natural place to draw the line All lemmas have just been moved, and none have been renamed. Some lemmas have had their `R` variables renamed to `M` to better reflect that they apply to monoids with zero. By grouping together the `monoid_with_zero` lemmas from separate files, it become apparent that there's some overlap. This PR does not attempt to clean this up, in the interest of limiting the the scope of this change to just moves.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually stop
algebra.ring.basicbeing imported intogroup_power.basicyet, but it makes it easier to make that change in future. Two ~300 line files are also slightly easier to manage than one ~600 line file, and ring/add_group feels like a natural place to draw the lineAll lemmas have just been moved, and none have been renamed. Some lemmas have had their
Rvariables renamed toMto better reflect that they apply to monoids with zero.By grouping together the
monoid_with_zerolemmas from separate files, it become apparent that there's some overlap.This PR does not attempt to clean this up, in the interest of limiting the the scope of this change to just moves.