Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(set_theory/game/pgame): ditch restricted #15037

Closed
wants to merge 23 commits into from
Closed

[Merged by Bors] - feat(set_theory/game/pgame): ditch restricted #15037

wants to merge 23 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jun 28, 2022 •
edited

We ditch pgame.restricted. The docstring erroneously claimed it to be something other than what it was, and in its current form, it really only served as a worse form of le_def. It was barely used anyways.

See also my comments on Zulip.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jun 28, 2022
@vihdzp vihdzp requested a review from alreadydone June 28, 2022 18:45
@vihdzp vihdzp marked this pull request as ready for review June 28, 2022 18:45
@vihdzp vihdzp changed the title No restricted feat(set_theory/game/pgame): ditch restricted Jun 28, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 28, 2022
@vihdzp vihdzp removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 19, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 28, 2022
bors bot pushed a commit that referenced this pull request Sep 28, 2022
@vihdzp
feat(set_theory/game/pgame): ditch restricted (#15037)
fe84059 
We ditch `pgame.restricted`. The docstring erroneously claimed it to be something other than what it was, and in its current form, it really only served as a worse form of `le_def`. It was barely used anyways.

See also my comments on [Zulip](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/Well-founded.20recursion.20for.20pgames/near/287531824).
@bors
Copy link

bors bot commented Sep 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/game/pgame): ditch restricted [Merged by Bors] - feat(set_theory/game/pgame): ditch restricted Sep 29, 2022
@bors bors bot closed this Sep 29, 2022
@bors bors bot deleted the no_restricted branch September 29, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone Awaiting requested review from alreadydone

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @mathlib-dependent-issues-bot @fpvandoorn