[Merged by Bors] - fix(order/basic): fix subtype.linear_order
#15056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
eric-wieser
reviewed
Jun 29, 2022
src/order/basic.lean
Outdated
| max := λ x y, ⟨max x y, max_rec' _ x.2 y.2⟩, | ||
| min := λ x y, ⟨min x y, min_rec' _ x.2 y.2⟩, | ||
| max_def := by { ext ⟨x, hx⟩ ⟨y, hy⟩, by_cases y ≤ x; simp [*, max_def, max_default] }, | ||
| min_def := by { ext ⟨x, hx⟩ ⟨y, hy⟩, by_cases x ≤ y; simp [*, min_def, min_default] }, |
There was a problem hiding this comment.
Does min_rec' work for this field?
There was a problem hiding this comment.
I'm rewriting linear_order.lift.
urkud
added
WIP
vihdzp
reviewed
Jul 1, 2022
| @@ -68,14 +65,6 @@ end | |||
|
|
|||
| /- TODO: automatic construction of dual definitions / theorems -/ | |||
There was a problem hiding this comment.
This comment doesn't seem relevant here anymore.
Co-authored-by: Violeta Hernández <vi.hdz.p@gmail.com>
…nity/mathlib into YK-linear-subtype
Currently, there is a diamond : |
urkud
added
awaiting-review
urkud
commented
Jul 1, 2022
urkud
commented
Jul 1, 2022
github-actions
bot
removed
the
awaiting-CI
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
This makes `subtype.lattice` definitionally equal to `linear_order.to_lattice`, after unfolding some (which?) semireducible definitions. * Rewrite `linear_order.lift` to allow custom `max` and `min` fields. Move the old definition to `linear_order.lift'`. * Use the new `linear_order.lift` to fix a non-defeq diamond on `subtype _`. * Use the new `linear_order.lift` in various `function.injective.linear_*` definitions.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
This makes `subtype.lattice` definitionally equal to `linear_order.to_lattice`, after unfolding some (which?) semireducible definitions. * Rewrite `linear_order.lift` to allow custom `max` and `min` fields. Move the old definition to `linear_order.lift'`. * Use the new `linear_order.lift` to fix a non-defeq diamond on `subtype _`. * Use the new `linear_order.lift` in various `function.injective.linear_*` definitions.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
subtype.linear_ordersubtype.linear_order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
subtype.latticedefinitionally equal tolinear_order.to_lattice, after unfolding some (which?) semireducible definitions.linear_order.liftto allow custommaxandminfields. Move the old definition tolinear_order.lift'.linear_order.liftto fix a non-defeq diamond onsubtype _.linear_order.liftin variousfunction.injective.linear_*definitions.