Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(category_theory/adjunction/*): making arguments implicit in adjuction.comp and two small lemmas about mates #15062

Closed
wants to merge 7 commits into from

Conversation

Julian-Kuelshammer
Copy link
Collaborator

@Julian-Kuelshammer Julian-Kuelshammer commented Jun 29, 2022

Working on adjunctions between monads and comonads, I noticed that adjunction.comp was defined with having the functors of one of the adjunctions explicit as well as the adjunction. However in the library, only adjunction.comp _ _ ever appears. Thus I found it natural to make these two arguments implicit, so that composition of adjunctions can now be written as adj1.comp adj2 instead of adj1.comp _ _ adj2.

Furthermore, I provide two lemmas about mates of natural transformations to and from the identity functor. The application I have in mind is to the unit/counit of a monad/comonad in case of an adjunction of monads and comonads, as studied already by Eilenberg and Moore.


Open in Gitpod

@Julian-Kuelshammer Julian-Kuelshammer added the WIP Work in progress label Jun 29, 2022
@Julian-Kuelshammer Julian-Kuelshammer changed the title feat(category_theory/adjunction/mate): two small lemmas about mates via adjunction.id chore(category_theory/adjunction/*): making arguments implicit in adjuction.comp and two small lemmas about mates Jun 30, 2022
@Julian-Kuelshammer Julian-Kuelshammer added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 30, 2022
@Julian-Kuelshammer Julian-Kuelshammer marked this pull request as ready for review June 30, 2022 12:18
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 11, 2022
bors bot pushed a commit that referenced this pull request Jul 11, 2022
…uction.comp and two small lemmas about mates (#15062)

Working on adjunctions between monads and comonads, I noticed that adjunction.comp was defined with having the functors of one of the adjunctions explicit as well as the adjunction. However in the library, only `adjunction.comp _ _` ever appears. Thus I found it natural to make these two arguments implicit, so that composition of adjunctions can now be written as `adj1.comp adj2` instead of `adj1.comp _ _ adj2`. 

Furthermore, I provide two lemmas about mates of natural transformations to and from the identity functor. The application I have in mind is to the unit/counit of a monad/comonad in case of an adjunction of monads and comonads, as studied already by Eilenberg and Moore.  



Co-authored-by: Julian-Kuelshammer <68201724+Julian-Kuelshammer@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory/adjunction/*): making arguments implicit in adjuction.comp and two small lemmas about mates [Merged by Bors] - chore(category_theory/adjunction/*): making arguments implicit in adjuction.comp and two small lemmas about mates Jul 11, 2022
@bors bors bot closed this Jul 11, 2022
@bors bors bot deleted the trans_self_id_lemmas branch July 11, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants