Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/set,topology): fix 2 lemma names #15079

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(data/set,topology): fix 2 lemma names #15079

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 1, 2022

  • rename set.quot_mk_range_eq to set.range_quotient_mk;
  • rename is_closed_infi_iff to is_closed_supr_iff.

Open in Gitpod

@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 1, 2022
eric-wieser
eric-wieser approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Jul 1, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 1, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 1, 2022
@urkud
Copy link
Member Author

urkud commented Jul 1, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 1, 2022
bors bot pushed a commit that referenced this pull request Jul 1, 2022
@urkud
chore(data/set,topology): fix 2 lemma names (#15079)
2ae2065 
* rename `set.quot_mk_range_eq` to `set.range_quotient_mk`;
* rename `is_closed_infi_iff` to `is_closed_supr_iff`.
@bors
Copy link

bors bot commented Jul 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/set,topology): fix 2 lemma names [Merged by Bors] - chore(data/set,topology): fix 2 lemma names Jul 1, 2022
@bors bors bot closed this Jul 1, 2022
@bors bors bot deleted the YK-fix-names branch July 1, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @eric-wieser @leanprover-community-bot-assistant